Re: [PATCH] make test/agent.c use new API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Filippo,

> I've fixed the space vs tab usage, sorry.
> I'm not sure how to handle this case:
> 
> -	if (dbus_message_is_method_call(msg, "org.bluez.Agent", "Request"))
> +	if (dbus_message_is_method_call(msg, "org.bluez.Agent", "RequestPinCode") ||
> +			dbus_message_is_method_call(msg, "org.bluez.Agent",
> +								"RequestPasskey"))
> 
> with proper indentation but not going over 80 columns, that's what I came up
> with, hope that's ok.

it is not, because you need to split them into two functions anyway. One
returns a string, the other a uint32. Please read agent-api.txt.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux