Hi Alok, One minor comment: On Fri, May 29, 2009, alokbarsode@xxxxxxxxx wrote: > +static int hciops_start_discovery(int index, gboolean periodic) > +{ > + inquiry_cp inq_cp; > + periodic_inquiry_cp cp; Put these two variables into the if-else statement since that's the only place where they are used. Otherwise the patch looks pretty good. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html