Hi Bing, > This driver, bt_mrvl, provides basic definitions and library functions > to support Marvell Bluetooth enabled devices, such as 88W8688 WLAN/BT > combo chip. > > This patch incorporates a lot of comments given by > Nicolas Pitre <nico@xxxxxxxxxxx>. Many thanks to Nicolas Pitre. > > Signed-off-by: Rahul Tank <rahult@xxxxxxxxxxx> > Signed-off-by: Bing Zhao <bzhao@xxxxxxxxxxx> > --- > drivers/bluetooth/Kconfig | 2 + > drivers/bluetooth/Makefile | 2 + > drivers/bluetooth/bt_mrvl/Kconfig | 12 + > drivers/bluetooth/bt_mrvl/Makefile | 7 + > drivers/bluetooth/bt_mrvl/btm_drv.h | 223 +++++++++++ > drivers/bluetooth/bt_mrvl/btm_main.c | 728 ++++++++++++++++++++++++++++++++++ > 6 files changed, 974 insertions(+), 0 deletions(-) > create mode 100644 drivers/bluetooth/bt_mrvl/Kconfig > create mode 100644 drivers/bluetooth/bt_mrvl/Makefile > create mode 100644 drivers/bluetooth/bt_mrvl/btm_drv.h > create mode 100644 drivers/bluetooth/bt_mrvl/btm_main.c the first thing that I need from you is to remove this vendor specific debug mess. You can use dynamic debug and hex dump infrastructure already present in the upstream kernel. For the driver name please do btmrvl.ko and btmrvl_sdio.ko or use the chipset specific code number. And I prefer not to have it in a subdirectory. So just prefix all your files with btmrvl_ Then please resend them and I do a detailed review. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
