Hi Johan, On Sun, May 17, 2009 at 4:24 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > Hi Alok, > > On Fri, May 15, 2009, Johan Hedberg wrote: >> I'm going through your patches now and I found at least one issue: >> >> > + hci_send_cmd(dd, OGF_HOST_CTL, OCF_WRITE_SCAN_ENABLE, >> > + 1, SCAN_DISABLED); >> >> This looks wrong. The last parameter should a pointer and not an integer. > hmmm right, I show assign 'SCAN_DISABLE' to a variable and send its address to hci_send_cmd. > There's another issue with this patch as well: > adapter.c: In function ‘set_mode’: > adapter.c:403: error: ‘dd’ may be used uninitialized in this function > > I'd have fixed both issues for you (since they are rather trivial) but > then your third patch doesn't apply cleanly anymore. So please fix these > issues, check that no patch causes any compilation warning or error, and > resend them. Thanks. > The 3rd patch has dependencies on the 1st patch (using hci_send_cmd for hci_send_req) . did u get time to test that patch? Thanks for fixing patch2. do you want me to rework all the patches so as to remove dependency on patch1? (which would basically mean removing that patch). Cheers, Alok > Johan > -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
