RE: bluetooth: module_refcount is not decreased when connection times out

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Hi Bing,
> 
> > > > The module refcount is increased by hci_dev_hold() call in hci_conn_add() in hci_conn.c, and it
> is
> > > decreased by hci_dev_put() call in "del_conn" (hci_sysfs.c).
> > > >
> > > > In case connection timeout happens, hci_dev_put() is never called.
> > >
> > > can you test the attached patch for quickly. It should fix it.
> >
> > It seems that hdev is "put" twice with the patch, if the connection fails.
> >
> > # hciconfig hci0 up
> > # lsmod | grep btusb				-> "used by" refcount = 1
> >
> > # hcitool cc <non-exisiting bdaddr>		-> will get timeout
> > # lsmod | grep btusb				-> "used by" refcount = 0 (??)
> >
> > # hcitool cc <non-exisiting bdaddr>		-> time out again
> > # lsmod | grep btusb				-> "used by" refcount = 4294967295 (??)
> 
> the previous patch has one tiny bug. Is this one better?
> 
> Regards
> 
> Marcel


Hi Marcel,

Thanks for the patch. It works perfectly.

Best regards,

Bing


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux