>>> Marcel Holtmann <marcel@xxxxxxxxxxxx> 05/02/09 12:57 AM >>> >Hi Jiri, > >> > Subject: bluetooth: Fix serialization when adding/deleting connections in hci_sysfs >> > >> > add_conn and del_conn should be serialized, but flush_workqueue can't be used >> > by the worker thread on it's own queue, so use flush_work to serialize add_conn >> > and del_conn against each other. >> > >> > Signed-off-by: Marc Pignat <marc.pignat@xxxxxxx> >> >> Acked-by: Jiri Kosina <jkosina@xxxxxxx> >> >> FWIW. > >nak from my side since I think it is the wrong fix. We really wanna wait >for all works to finish here. This includes work from other connection >attempts or terminations. IMHO, there is no need to wait for work currently running, since this is a singlethread workqueue. But it is perhaps simpler to use a lock (mutex or watherver locking primitive). Regards Marc -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
