Hi Scott, On Thu, Apr 23, 2009, Scott Talbot wrote:
Set the high bit in the op value for the button released event rather than clearing the entire field. --- audio/control.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/audio/control.c b/audio/control.c index e0451e7..5cc4a31 100644 --- a/audio/control.c +++ b/audio/control.c @@ -937,7 +937,7 @@ static int avctp_send_passthrough(struct control *control, uint8_t op) /* Button release */ avctp->transaction = transaction++; - operands[0] &= 0x80; + operands[0] |= 0x80; return write(sk, buf, sizeof(buf)); }
Yeah, stupid mistake by me (though headsets I tested with didn't seem to mind this). Thanks for catching it! The patch is now pushed upstream.
Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
