Re: [PATCH] Wacom Bluetooth mode-2 activation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bastien,

> Patch is necessary to make the Wacom Bluetooth driver I posted to
> linux-input work as expected. I've tested this successfully with my
> tablet[1].

this maybe sound like a nit-pick, but please add an extra empty line
between the if-statement and the ioctl.

+               write(sk, buf, sizeof(buf));
+       }
        err = ioctl_connadd(req);

The original code had one and so should have the new one with this extra
quirk.

Also can we please check at least the return value of write().

+               write(sk, buf, sizeof(buf));

Check the return value and at minimum have an error message printed.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux