On Fri, 2009-03-13 at 15:15 -0300, Johan Hedberg wrote: > Hi Bastien, > > On Fri, Mar 13, 2009, Bastien Nocera wrote: > > FWIW, I just copied the coding style from the function 5 lines above it. > > Yeah, the SDP code is full of broken coding style that we just haven't > had the time to fix. > > > Patches attached. > > Thanks. I had to fix the following warning in the cups patch, but > otherwise they were fine: > main.c: In function ‘device_get_ieee1284_id’: > main.c:129: error: ‘id’ may be used uninitialized in this function I didn't see this. Must be my gcc being low on warnings. I did notice a "return FALSE" in device_get_ieee1284_id(), when it should be a "return NULL" though. Could you get that pushed? > The patches have now been pushed upstream. Great, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
