Hi Marcel, On Sat, Feb 28, 2009 at 10:35 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > Hi Philipp, > >> pcmcia_loop_config returns 0 on success. >> >> Signed-off-by: Philipp Zabel <philipp.zabel@xxxxxxxxx> >> --- >> drivers/bluetooth/dtl1_cs.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/bluetooth/dtl1_cs.c b/drivers/bluetooth/dtl1_cs.c >> index 901bdd9..e0ee642 100644 >> --- a/drivers/bluetooth/dtl1_cs.c >> +++ b/drivers/bluetooth/dtl1_cs.c >> @@ -616,7 +616,7 @@ static int dtl1_config(struct pcmcia_device *link) >> >> /* Look for a generic full-sized window */ >> link->io.NumPorts1 = 8; >> - if (!pcmcia_loop_config(link, dtl1_confcheck, NULL)) >> + if (pcmcia_loop_config(link, dtl1_confcheck, NULL)) >> goto failed; >> >> i = pcmcia_request_irq(link, &link->irq); > > can you check the other Bluetooth PCMCIA drivers, too. bluecard_cs doesn't use pcmcia_loop_config. bt3c_cs and btuart_cs both have something like if (!pcmcia_loop_config(...)) goto found_port; instead, which looks fine. > One of the PCMCIA > subsystem changes might have screwed this up and affects more drivers > than expected. "pcmcia: use pcmcia_loop_config in bluetooth drivers" (ed58872aa33e16a0d5352080e47c65fa14e6ad1c) only touched bt3_cs, btuart_cs and dtl1_cs. regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
