Re: [PATCH] Fix segfault: If the interface name is NULL the bluetoothd daemon will crash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Frieder,

> ---
>  gdbus/object.c |   11 ++++++-----
>  1 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/gdbus/object.c b/gdbus/object.c
> index 0786aeb..d920eac 100644
> --- a/gdbus/object.c
> +++ b/gdbus/object.c
> @@ -224,11 +224,12 @@ static struct interface_data *find_interface(GSList *interfaces,
>  {
>  	GSList *list;
>  
> -	for (list = interfaces; list; list = list->next) {
> -		struct interface_data *iface = list->data;
> -		if (!strcmp(name, iface->name))
> -			return iface;
> -	}
> +	if (name)
> +		for (list = interfaces; list; list = list->next) {
> +			struct interface_data *iface = list->data;
> +			if (!strcmp(name, iface->name))
> +				return iface;
> +		}
>  
>  	return NULL;
>  }

what about something like this:

	if (name == NULL)
		return NULL;

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux