Hi Marcel, On Fri, Jan 16, 2009 at 1:47 AM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > Hi, > >> > why do you wanna set AUTH_PENDING again. That is not needed we only >> > wanna know once encryption comes back on. If no in time, then we just >> > disconnect the link. That simple. >> > >> >> b) I also see that we are not clearing the timer and hence after >> >> RFCOMM_AUTH_TIMEOUT period expires we bring down the RFCOMM connection >> >> even though the encryption has been established. >> > >> > Good catch. Fixed it. >> >> Cool. Can you upload it to bluetooth-testing git ? I saw a related >> problem while looking at the timer issue and wanted to see if the fix >> takes care of it. > > I am in the process in doing so, but there are other important things > that need to be done first. Sorry to push you on this, is this patch been uploaded ? >> The timer thats started in rfcomm_security_cfm (for the drop in >> encryption) does get cleared in rfcomm_process_dlcs >> but then we have some data to send. So we send the RFCOMM PN packet >> just after encryption is re-established. >> This results in a new timer being started in rfcomm_process_dlcs and >> we don't get the UA packet to clear this timer and hence when >> the timer expires, the connection is dropped. > > I think you are confusing the work-flow here. The initial stage here is > that we get security_cfm when establishing the connection. Then we will > either reject or accept the link depending if encryption is enabled or > not. In case of dropping encryption during an existing connection we > don't need to send PN again. We do have to be in BT_CONNECTED state to > have the encryption droping check to kick in. The SEC_PENDING only > ensures that we stay encrypted. It has nothing to with the auth step. > Also we combine auth+encrypt since one without the other makes no sense > at all. So the initial call of security_cfm will always include auth and > encrypt enabled. > > Regards > > Marcel > Regards Jaikumar -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
