> There are some parts that look a bit redundant/suspicious:
>
> > @@ -47,7 +47,7 @@ static ssize_t __read(int fd, void *buf, size_t count)
> > while (count > 0) {
> > len = read(fd, buf + pos, count);
> > if (len <= 0)
> > - return len;
> > + return pos > len ? pos : len;
> >
> > count -= len;
> > pos += len;
>
> Is the ternary '?' operator really needed here? In this part of code we know
> for sure that 'len' is less or equal to zero, also 'pos ' is a positive number
> or zero. Having just 'return pos' should be enough.
No. If read returns an error, the this error is passed to __read, too.
> > @@ -188,6 +188,8 @@ static void encode(char *filename, int subbands, int
> > bitpool, int joint,
> >
> > len = sbc_encode(&sbc, input, size,
> > output, sizeof(output), &encoded);
> > + if (len <= 0)
> > + break;
> > if (len < size)
> > memmove(input, input + len, size - len);
>
> If the return value is negative, there was some error. Probably showing some
> kind of error message is appropriate here instead of just silently bailing
> out.
Yes, if len is -1 then errno depended message shall be printed and the program should quit.
CH
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
