Hello Marcel, Thank you for your comments. Here are reworked fixed patches attached. I've missed when you changed repo :). I've noticed IPC infrastructure and going to make use of it in future version. I fully agree for code style. Sorry for that. Was too stupid to setup my editor correctly :). Vale, event On Wed, Dec 17, 2008 at 04:48, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > Hi Leonid, > >> I've implemented gateway profile. I've tested basic things, like >> place/cancel/answer call. Others are in development. Some could not be >> tested as my carrier doesn't provide corresponding services (like >> 3-way call, etc.) so any help welcome. > > thanks for the works, but can you please base the patch against the > latest GIT tree. It is kinda hard to review things that might already > have been implemented like sco_listen. > > audio/audio-api.txt | 94 +++++ > audio/device.h | 7 > audio/gateway.c | 938 +++++++++++++++++++++++++++++++++++++++++++++++++++ > audio/gateway.h | 11 > audio/manager.c | 124 ++++-- > common/glib-helper.c | 85 +++- > common/glib-helper.h | 1 > 7 files changed, 1205 insertions(+), 55 deletions(-) > > So any changes to glib-helper.[ch] have to be in a separate patch and > need to be discussed independent from the gateway implementation. > > Any audio-api.txt stuff should also go separately since that has to be > discussed. Also we can't send PCM data over D-Bus. It just doesn't work > like that. We do have the internal IPC for that and plugins for ALSA, > GStreamer and PulseAudio that should be used. > > However the most important part is that you follow the coding style and > that is the kernel coding style. You make it really hard for us to > review the code like this and it can't be applied. I really want you to > add support for the gateway role to BlueZ, but the overall code in the > project needs to follow the same rules. > > So please fix these issues first and then we do a deep review of it. > > Regards > > Marcel > > >
Attachment:
gateway.patch
Description: Binary data
Attachment:
audio-api.patch
Description: Binary data
