Re: [PATCH] Fix PS3 BD remote input event generation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

> > - Fix byte-reading in the decode function by using a guint8, instead
> > of an int, we were overreading and were getting keycodes of
> > 0xffffff44 when we wanted a single byte of 0x44.
> > - Remove use of KEY_REMOTE_X, those keys never got upstream, and the
> > values they were defined at are now used for completely different
> > keys
> > - Update uinput.h with the latest keycodes from 2.6.27
> 
> The patch has been pushed upstream. Thanks!

this patch should have been split at least into 2 pieces (maybe 3). The
uinput update at least should have been separate. We are using GIT and
there is no reason to push combined patches ever. I do _NOT_ wanna have
big patches that fix multiple things. Break them down.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux