On Tuesday, 30 of September 2008, Marcel Holtmann wrote: > Hi Rafael, > > > > >> Rafael, can you pull from my tree and test the changes: > > > >> > > > >> git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/ > > > >> bluetooth-2.6.git > > > >> > > > >> It would be interesting if these fixes are enough. > > > > > > > > They appear to be enough. I haven't had any suspend/resume failures > > > > with them > > > > applied. > > > > > > so it works _without_ applying patch-btusb-suspend. > > > > Well, unfortunately I spoke too soon. > > > > I'm still seeing post-hibernation crashes triggered by the bluetooth user land > > trying to use the device handled by btusb. They happen every second > > hibernation, more or less, and apparently they are oopses in various code > > paths not directly related to bluetooth, like ext3 (memory corruption or > > what?). > > I pushed two extra patches to my bluetooth-2.6 repository: > > git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git > > One is fixing a double-free in the error path. This error path can be > triggered during suspend/resume if the USB core just disconnects the > device. Please check if that fixes it for you. > > > With patch-btusb-suspend applied I don't see them (actually I have to use > > a slightly modified version of the patch which is appended). > > > > Interestingly enough, suspend to RAM works without any visible problems. > > As Oliver said, the USB core should do the right thing when no suspend > and resume callbacks are provided. I looked through the code so many > times now and I am running out of ideas what can happen. > > Lets try it one last time without the suspend patch, but the double free > fix and see if that works. Otherwise I really give up. This time I cannot reproduce the hibernation issue without the suspend patch, so it appears that your double-free fix works for me. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
