On Tue 2008-08-26 11:56:47, Pavel Machek wrote: > On Mon 2008-08-25 12:43:46, Oliver Neukum wrote: > > Am Freitag 22 August 2008 16:31:10 schrieb Marcel Holtmann: > > > > > Please explain the tx_in_flight stuff to me. It looks unneeded since we > > > > > anchor all TX URBs anyway. > > > > > > > > The completion of an URB may happen after the autosuspend timeout passed. > > > > But we cannot use the pm counters as they are not accessible in interrupt. > > > > Hence we must maintain a counter ourselves. > > > > > > Can we not just check the number of URBs in the anchor? I am against > > > just duplicating a counter, but then lets call it it what it is to make > > > it gets not misused. It is a purely a PM counter. > > > > > > > An excellent suggestion allowing major simplifications. This version works > > for me. It required an extension of the anchor API, so it obsoletes > > the split-up you've done. Therefore the whole thing comes as a big patch > > against rc4, easy to test. > > I could not get it to apply over -rc4-git, usb seems to be changing > under us :-(. After manual fixup (conflict was in comment), I still > get > > LD .tmp_vmlinux1 > drivers/built-in.o: In function `btusb_suspend': > btusb.c:(.text+0x20a578): undefined reference to `usb_anchor_empty' > drivers/built-in.o: In function `btusb_resume': > btusb.c:(.text+0x20ade6): undefined reference to `usb_get_from_anchor' > btusb.c:(.text+0x20ae01): undefined reference to > `usb_scuttle_anchored_urbs' > make: *** [.tmp_vmlinux1] Error 1 > 40.09user 7.55system 47.97 (0m47.971s) elapsed 99.34%CPU > pavel@amd:/data/l/linux-good$ > > ...probably the "already applied" patch it complained about was not so > applied after all. > > ...ok, I got it to apply, compile, resulting patch is attached. And it worked for me, but suspend died. I'll verify if that's a problem in vanilla -rc4-git, too. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
