Hi Marcel, On Mon, Aug 18, 2008 at 09:57:11PM +0200, Marcel Holtmann wrote: > > CC: Marcel Holtmann <marcel@xxxxxxxxxxxx> > > CC: linux-bluetooth@xxxxxxxxxxxxxxx > > Signed-off-by: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx> > > I know that the Bluetooth PCMCIA drivers are not the best examples for > coding style, but please double check your whitespaces/tabs. We don't > wanna make it worse. actually, I'm pondering making a CodingStyle cleanup of the whole PCMCIA subsystem for drivers/pcmcia/ is so unbelievable un-CodingStyle... but: > > > - return get_tuple(handle, tuple, parse); > > + unsigned long try = (unsigned long) priv_data; > > + > > + if (cf->vpp1.present & (1 << CISTPL_POWER_VNOM)) > > + p_dev->conf.Vpp = cf->vpp1.param[CISTPL_POWER_VNOM] / 10000; something went badly wrong here, will fix it up (probably in a follow-up patch). Thanks, Dominik -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html