Am Montag 04 August 2008 22:24:08 schrieb Marcel Holtmann: > Hi Oliver, > > > > >>> Then why do you implement this option for hci_usb? > > > >>> And why can the other IGNORE options be overridden? > > > >> > > > >> if I wanna use the generic Bluetooth descriptor for matching, I > > > >> need a > > > >> way to mark broken devices as to be ignored. Otherwise I would have a > > > >> really long list of matching vendor and product ids. > > > > > > > > True, but if btusb is to replace hci_usb, the module options should > > > > match. > > > > So will you remove that option in hci_usb? > > > > > > the override_ignore is your invention. So what do you mean? > > > > Hm, I may be smoking strange kernels, but I copied this as far as I can tell > > from 2.6.25 hci_usb and merely renamed it because "ignore" seemed too > > generic to me. Could you check we are talking about the same parameter? > > the generic ignore parameter can be removed. There is no other way to > deal with Bluetooth in Linux and we can use other ways to unattach a > driver from a device. Exactly. Therefore I wonder whether this in vanilla hci_usb is not a mistake: if (ignore || id->driver_info & HCI_IGNORE) return -ENODEV; if (ignore_dga && id->driver_info & HCI_DIGIANSWER) return -ENODEV; if (ignore_csr && id->driver_info & HCI_CSR) return -ENODEV; And should be (ignore && id->driver_info & HCI_IGNORE) or negatively formulated (!ignore && id->driver_info & HCI_IGNORE) so that the blacklist is used by default. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
