Re: [patch 3/3] hci_usb.h: fix hard-to-trigger race

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrew,

If someone tries to _urb_unlink while _urb_queue_head is running,
he'll see
_urb->queue == NULL and fail to do any locking.  Prevent that from
happening
by strategically placed barriers.

let me repeat this, the hci_usb driver is not worth fixing. Doing our
own URB handling is a bad idea. The btusb driver should fix all of
this. Only exception is that it is missing all the quirks, but that
was me being lazy.


ok... But as long as the old code is buildable and installable, we should
fix bugs in it?

I am okay with it and happy to accept any fixes, but to be quite honest, that this driver still works is in some cases pure luck. Doing the URB handling by ourself is really simply plain work. No excuses here and parts of it is my fault. I know that. Hence I started a new implementation from scratch.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux