Re: [PATCH RFC 06/16] block: Limit atomic writes according to bio and queue limits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: John Garry <john.g.garry@xxxxxxxxxx>
Subject: Re: [PATCH RFC 06/16] block: Limit atomic writes according to bio and queue limits
From: Keith Busch <kbusch@xxxxxxxxxx>
Date: Wed, 3 May 2023 12:53:43 -0600
Cc: axboe@xxxxxxxxx, hch@xxxxxx, sagi@xxxxxxxxxxx, martin.petersen@xxxxxxxxxx, djwong@xxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, brauner@xxxxxxxxxx, dchinner@xxxxxxxxxx, jejb@xxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, paul@xxxxxxxxxxxxxx, jmorris@xxxxxxxxx, serge@xxxxxxxxxx
In-reply-to: <20230503183821.1473305-7-john.g.garry@oracle.com>
References: <20230503183821.1473305-1-john.g.garry@oracle.com> <20230503183821.1473305-7-john.g.garry@oracle.com>

On Wed, May 03, 2023 at 06:38:11PM +0000, John Garry wrote:
> +	unsigned int size = (atomic_write_max_segments - 1) *
> +				(PAGE_SIZE / SECTOR_SIZE);

Maybe use PAGE_SECTORS instead of recalculating it.

Follow-Ups:
- Re: [PATCH RFC 06/16] block: Limit atomic writes according to bio and queue limits
  - From: John Garry

References:
- [PATCH RFC 00/16] block atomic writes
  - From: John Garry
- [PATCH RFC 06/16] block: Limit atomic writes according to bio and queue limits
  - From: John Garry

Prev by Date: Re: [PATCH RFC 16/16] nvme: Support atomic writes
Next by Date: Re: [PATCH 05/15] block: fix not to apply bip information in blk_rq_bio_prep()
Previous by thread: [PATCH RFC 06/16] block: Limit atomic writes according to bio and queue limits
Next by thread: Re: [PATCH RFC 06/16] block: Limit atomic writes according to bio and queue limits
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]