Hello Jens, On Fri, Apr 28, 2023 at 11:28:14AM -0600, Jens Axboe wrote: > On 4/21/23 5:44?AM, Breno Leitao wrote: > > These three patches prepare for the sock support in the io_uring cmd, as > > described in the following RFC: > > > > https://lore.kernel.org/lkml/20230406144330.1932798-1-leitao@xxxxxxxxxx/ > > > > Since the support linked above depends on other refactors, such as the sock > > ioctl() sock refactor[1], I would like to start integrating patches that have > > consensus and can bring value right now. This will also reduce the patchset > > size later. > > > > Regarding to these three patches, they are simple changes that turn > > io_uring cmd subsystem more flexible (by passing the whole SQE to the > > command), and cleaning up an unnecessary compile check. > > > > These patches were tested by creating a file system and mounting an NVME disk > > using ubdsrv/ublkb0. > > Looks mostly good to me, do agree with Christoph's comments on the two > patches. Can you spin a v3? Would be annoying to miss 6.4 with this, as > other things will be built on top of it. Sure. I've just sent V3 with all the fixes discussed in this email thread. Here is the link: https://lkml.org/lkml/2023/4/30/91