Re: [PATCH v3 4/9] block: mq-deadline: Clean up deadline_check_fifo()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Bart Van Assche <bvanassche@xxxxxxx>
Subject: Re: [PATCH v3 4/9] block: mq-deadline: Clean up deadline_check_fifo()
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 28 Apr 2023 07:46:18 +0200
Cc: Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, Jaegeuk Kim <jaegeuk@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>
In-reply-to: <20230424203329.2369688-5-bvanassche@acm.org>
References: <20230424203329.2369688-1-bvanassche@acm.org> <20230424203329.2369688-5-bvanassche@acm.org>
User-agent: Mutt/1.5.17 (2007-11-01)

On Mon, Apr 24, 2023 at 01:33:24PM -0700, Bart Van Assche wrote:
> Change the return type of deadline_check_fifo() from 'int' into 'bool'.
> Use time_is_before_eq_jiffies() instead of time_after_eq(). No
> functionality has been changed.

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH v3 0/9] mq-deadline: Improve support for zoned block devices
  - From: Bart Van Assche
- [PATCH v3 4/9] block: mq-deadline: Clean up deadline_check_fifo()
  - From: Bart Van Assche

Prev by Date: Re: [PATCH v3 3/9] block: Introduce blk_rq_is_seq_zoned_write()
Next by Date: Re: [PATCH v3 5/9] block: mq-deadline: Simplify deadline_skip_seq_writes()
Previous by thread: [PATCH v3 4/9] block: mq-deadline: Clean up deadline_check_fifo()
Next by thread: [PATCH v3 5/9] block: mq-deadline: Simplify deadline_skip_seq_writes()
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux