Re: [PATCH v2 02/11] block: Micro-optimize blk_req_needs_zone_write_lock()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/18/23 21:11, Christoph Hellwig wrote:
On Tue, Apr 18, 2023 at 03:39:53PM -0700, Bart Van Assche wrote:
Instead of using the following expression to translate a request pointer
into a request queue pointer: rq->q->disk->part0->bd_queue, use the
following expression: rq->q.

This looks correct, but I also kinda hate adding queue back in more
places.

Hi Christoph,

How about changing queue_op_is_zoned_write() into disk_op_is_zoned_write()? That won't be as efficient as patch 2/11 in this series but still removes the 'part0' dereference.

Thanks,

Bart.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux