Re: [PATCH] block: fix a crash when bio_for_each_folio_all iterates over an empty bio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Mikulas Patocka <mpatocka@xxxxxxxxxx>
Subject: Re: [PATCH] block: fix a crash when bio_for_each_folio_all iterates over an empty bio
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Mon, 17 Apr 2023 20:32:54 +0100
Cc: Jens Axboe <axboe@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, "Darrick J. Wong" <djwong@xxxxxxxxxx>, Mike Snitzer <msnitzer@xxxxxxxxxx>, dm-devel@xxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx
In-reply-to: <alpine.LRH.2.21.2304171433370.17217@file01.intranet.prod.int.rdu2.redhat.com>
References: <alpine.LRH.2.21.2304171433370.17217@file01.intranet.prod.int.rdu2.redhat.com>

On Mon, Apr 17, 2023 at 03:11:57PM -0400, Mikulas Patocka wrote:
> If we use bio_for_each_folio_all on an empty bio, it will access the first
> bio vector unconditionally (it is uninitialized) and it may crash
> depending on the uninitialized data.

Wait, how do we have an empty bio in the first place?

Follow-Ups:
- Re: [PATCH] block: fix a crash when bio_for_each_folio_all iterates over an empty bio
  - From: Christoph Hellwig
- Re: [PATCH] block: fix a crash when bio_for_each_folio_all iterates over an empty bio
  - From: Mikulas Patocka

References:
- [PATCH] block: fix a crash when bio_for_each_folio_all iterates over an empty bio
  - From: Mikulas Patocka

Prev by Date: Re: [PATCH v6 06/18] dm: Add support for block PR read keys/reservation
Next by Date: Re: [PATCH 3/7] blk-mq: defer to the normal submission path for non-flush flush commands
Previous by thread: [PATCH] block: fix a crash when bio_for_each_folio_all iterates over an empty bio
Next by thread: Re: [PATCH] block: fix a crash when bio_for_each_folio_all iterates over an empty bio
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]