On Sun, Apr 16, 2023 at 09:52:08PM -0700, Christoph Hellwig wrote: > On Fri, Apr 07, 2023 at 04:37:22PM +0800, Ming Lei wrote: > > All ublk commands(control, IO) should have taken ioctl command encoding > > from the beginning, > > Why? The traditional ioctl command encodes type/nr/dir info, and basically each command is unique if every driver respects the rule, so at least: 1) driver can figure out wrong command sent from userspace easily 2) easier for security subsystem audit[1] [1] https://lore.kernel.org/io-uring/CAHC9VhSVzujW9LOj5Km80AjU0EfAuukoLrxO6BEfnXeK_s6bAg@xxxxxxxxxxxxxx/ thanks, Ming
