On 4/15/23 11:51 PM, Christoph Hellwig wrote: > On Fri, Apr 14, 2023 at 07:48:47AM -0600, Jens Axboe wrote: >> This moves struct device out-of-line as it's just used at open/close >> time, so we can keep some of the commonly used fields closer together. >> On a standard setup, it also reduces the size from 864 bytes to 848 >> bytes. Yes, struct device is a pig... > > Maybe add a comment about keeping struct device last and why? Sure, done. -- Jens Axboe