On Thu, 13 Apr 2023 08:40:37 +0200, Christoph Hellwig wrote:
> in context of his latest series Bart commented that it's too hard
> to find all spots that do a head insertation into the blk-mq dispatch
> queues. This series collapses various far too deep callchains, drop
> two of the three bools and then replaced the final once with a greppable
> constant.
>
> This will create some rebased work for Bart of top of the other comments
> he got, but I think this will allow us to sort out some of the request
> order issues much better while also making the code a lot more readable.
>
> [...]
Applied, thanks!
[01/20] blk-mq: don't plug for head insertions in blk_execute_rq_nowait
commit: 50947d7fe9fa6abe3ddc40769dfb02a51c58edb6
[02/20] blk-mq: remove blk-mq-tag.h
commit: bebe84ebeec4d030aa65af58376305749762e5a0
[03/20] blk-mq: include <linux/blk-mq.h> in block/blk-mq.h
commit: 90110e04f265b95f59fbae09c228c5920b8a302f
[04/20] blk-mq: move more logic into blk_mq_insert_requests
commit: 94aa228c2a2f6edc8e9b7c4745942ea4c5978977
[05/20] blk-mq: fold blk_mq_sched_insert_requests into blk_mq_dispatch_plug_list
commit: 05a93117703e7b2e40fa9193e622079b30395bcc
[06/20] blk-mq: move blk_mq_sched_insert_request to blk-mq.c
commit: 2bd215df791b5d36ca1d20c07683100b48310cc2
[07/20] blk-mq: fold __blk_mq_insert_request into blk_mq_insert_request
commit: a88db1e0003eda8adbe3c499b81f736d8065b952
[08/20] blk-mq: fold __blk_mq_insert_req_list into blk_mq_insert_request
commit: 4ec5c0553c33e42f2d650785309de17d4cb8f5ba
[09/20] blk-mq: remove blk_flush_queue_rq
commit: a4fa57ffb7671c2df4ce597d03ef9f7d6d905a60
[10/20] blk-mq: refactor passthrough vs flush handling in blk_mq_insert_request
commit: 53548d2a945eb2c277332c66f57505881392e5a9
[11/20] blk-mq: refactor the DONTPREP/SOFTBARRIER andling in blk_mq_requeue_work
commit: a1e948b81ad21d635b99c1284f945423cb02b4c4
[12/20] blk-mq: factor out a blk_mq_get_budget_and_tag helper
commit: 2b71b8770710f2913e29053f01b6c7df1a5c7f75
[13/20] blk-mq: fold __blk_mq_try_issue_directly into its two callers
commit: e1f44ac0d7f48ec44a1eacfe637e545c408ede40
[14/20] blk-mq: don't run the hw_queue from blk_mq_insert_request
commit: f0dbe6e88e1bf4003ef778527b975ff60dbdd35a
[15/20] blk-mq: don't run the hw_queue from blk_mq_request_bypass_insert
commit: 2394395cd598f6404c57ae0b63afb5d37e94924d
[16/20] blk-mq: don't kick the requeue_list in blk_mq_add_to_requeue_list
commit: 214a441805b8cc090930fb00193125e22466a95a
[17/20] blk-mq: pass a flags argument to blk_mq_insert_request
commit: 710fa3789ed94ceee9675f8e189aaf3e7525269a
[18/20] blk-mq: pass a flags argument to blk_mq_request_bypass_insert
commit: 2b5976134bfbc753dec6281da0890c5f194c00c9
[19/20] blk-mq: pass a flags argument to elevator_type->insert_requests
commit: 93fffe16f7ee18600f15838e2e8b5cf353f245c8
[20/20] blk-mq: pass a flags argument to blk_mq_add_to_requeue_list
commit: b12e5c6c755ae8bec44723f77f037873e3d08021
Best regards,
--
Jens Axboe
