On Wed, Apr 12, 2023 at 04:33:04PM +0900, Damien Le Moal wrote: > I am not worried about the values shown by the trace entries, but rather the > order of the inserts: with the trace call outside the lock, the trace may end up > showing an incorrect insertion order ? ... turns out none of the other calls to trace_block_rq_insert is under ctx->lock either. The I/O scheduler ones are under their own per-request_queue locks, so maybe that counts as ordering, but blk_mq_insert_requests doesn't lock at all.