On (23/04/11 19:14), Christoph Hellwig wrote: > read_from_bdev_sync is currently only compiled for non-4k PAGE_SIZE, > which means it won't be built with the most common configurations. > > Replace the ifdef with a check for the PAGE_SIZE in an if instead. > The check uses an extra symbol and IS_ENABLED to allow the compiler > to eliminate the dead code, leading to the same generated code size: > > text data bss dec hex filename > 16709 1428 12 18149 46e5 drivers/block/zram/zram_drv.o.old > 16709 1428 12 18149 46e5 drivers/block/zram/zram_drv.o.new > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Reviewed-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>