Re: [PATCH 1/2] blk-mq: call blk_mq_hctx_stopped in __blk_mq_run_hw_queue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 12, 2023 at 05:13:05PM +0800, Ming Lei wrote:
> > +	if (blk_mq_hctx_stopped(hctx))
> > +		return;
> >  	blk_mq_run_dispatch_ops(hctx->queue,
> >  			blk_mq_sched_dispatch_requests(hctx));
> 
> The above new check isn't needed actually, since blk_mq_sched_dispatch_requests()
> does check it with rcu read lock held, which should be more reliable.  

The check is not new, it is just moved.   But yes, we could probably
just remove it instead.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux