On 4/12/23 18:17, Nitesh Shetty wrote: > On 23/04/11 09:08PM, Chaitanya Kulkarni wrote: >> Make sure to check device queue mode in the null_validate_conf() >> and return error for NULL_Q_RQ as we don't allow legacy I/O path, > > Can't we do away with NULL_Q_RQ defination itself ? > I mean, since I see in code we are not using NULL_Q_RQ anywhere, > if we can remove NULL_Q_RQ defination from enum in null_blk.h, > we can remove your suggested check, as well as check in null_init. I think it is being kept around to avoid reusing this value to not confuse old scripts. > > --Nitesh Shetty > >
