On 4/12/23 00:57, Damien Le Moal wrote: > On 4/12/23 13:08, Chaitanya Kulkarni wrote: >> Make sure to check device queue mode in the null_validate_conf() >> and return error for NULL_Q_RQ as we don't allow legacy I/O path, >> without this patch we get OOPs when queue mode is set to 1 from >> configfs, following are repro steps :- > Looks OK but the patch title is a little odd as I do not see what memory backing > has to do with checking the correctness of queue_mode. So what about something like: > > null_blk: Always check queue mode setting from configfs agree.. > for the patch title ? > > With that fixed, > > Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx> > > > will send a v2 with that fix with your review tag, thanks for the review. -ck
