On 4/12/23 14:32, Christoph Hellwig wrote: > Due the wildly different behavior based on the bypass_insert argument, s/Due/Due to > not a whole lot of code in __blk_mq_try_issue_directly is actually shared > between blk_mq_try_issue_directly and blk_mq_request_issue_directly. > > Remove __blk_mq_try_issue_directly and fold the code into the two callers > instead. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx> Otherwise looks good to me. Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
