Re: [PATCH 14/16] blk-mq: pass a flags argument to blk_mq_insert_request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/11/23 06:33, Christoph Hellwig wrote:
Replace the at_head bool with a flags argument that so far only contains
a single BLK_MQ_INSERT_AT_HEAD value.  This makes it much easier to grep
for head insertations into the blk-mq dispatch queues.

insertations -> insertions

+#define BLK_MQ_INSERT_AT_HEAD		(1U << 0)

Has it been considered to introduce a new bitwise type for this flag? That would allow sparse to detect accidental conversions from bool into flag and vice versa.

Thanks,

Bart.




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux