On 4/10/23 23:38, Christoph Hellwig wrote:
On Mon, Apr 10, 2023 at 05:15:44PM -0700, Bart Van Assche wrote:
+ blk_mq_sched_insert_request(rq, /*at_head=*/false,
+ /*run_queue=*/true, /*async=*/true);
And place drop these silly comments. If you want to do something about
this rather suboptimal interface convert the three booleans to a flags
argument with properly named flags.
I will remove these comments, but it is not clear to me what is silly about
these comments. There are even tools that can check the correctness of these
comments. See also
https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html
- if ((rq->rq_flags & RQF_FLUSH_SEQ) || blk_rq_is_passthrough(rq))
- return true;
-
- return false;
+ return req_op(rq) == REQ_OP_FLUSH || blk_rq_is_passthrough(rq);
This just seem like an arbitrary reformatting. While I also prefer
your new version, I don't think it belongs into this patch.
I will move this change into a patch of its own.
Thanks,
Bart.
