On 06. 04. 23 22:32, Milan Broz wrote:
On 4/6/23 15:19, Ondrej Kozina wrote:
Locking range start and locking range length
attributes may be require to satisfy restrictions
exposed by OPAL2 geometry feature reporting.
...
+ dev->align_required = (geo->reserved01 & 0b10000000) ? 1 : 0;
I am not sure if we can use 0b prefix as it is compiler extension (not in C standard, IIRC).
Anyway, align_required returns always 0 for my test drives even when discovery shows ALIGN = 1.
Does it mask the correct bit?
Yikes, sending a fix right now and my apologies for the rushed patch.
O.
Other geometry attributes work correctly.
Milan