Re: [PATCH v6 19/19] ata: libata: handle completion of CDL commands using policy 0xD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Niklas Cassel <nks@xxxxxxxxxxx>
Subject: Re: [PATCH v6 19/19] ata: libata: handle completion of CDL commands using policy 0xD
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 11 Apr 2023 08:20:16 +0200
Cc: Jens Axboe <axboe@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>, Bart Van Assche <bvanassche@xxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Hannes Reinecke <hare@xxxxxxx>, Damien Le Moal <dlemoal@xxxxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, linux-ide@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Niklas Cassel <niklas.cassel@xxxxxxx>
In-reply-to: <20230406113252.41211-20-nks@flawful.org>
References: <20230406113252.41211-1-nks@flawful.org> <20230406113252.41211-20-nks@flawful.org>
User-agent: Mutt/1.5.17 (2007-11-01)

> +extern int ata_eh_read_sense_success_ncq_log(struct ata_link *link);

Nit: no need for the extern.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH v6 00/19] Add Command Duration Limits support
  - From: Niklas Cassel
- [PATCH v6 19/19] ata: libata: handle completion of CDL commands using policy 0xD
  - From: Niklas Cassel

Prev by Date: Re: [PATCH v6 18/19] ata: libata: set read/write commands CDL index
Next by Date: Re: [PATCH v6 06/19] scsi: support retrieving sub-pages of mode pages
Previous by thread: [PATCH v6 19/19] ata: libata: handle completion of CDL commands using policy 0xD
Next by thread: [PATCH v6 09/19] scsi: allow enabling and disabling command duration limits
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]