On Apr 10, 2023 / 18:13, Kanchan Joshi wrote:
> On Fri, Apr 07, 2023 at 05:07:46PM +0900, Shin'ichiro Kawasaki wrote:
[...]
> > > +requires() {
> > > + _nvme_requires
> > > + _have_kver 6 1
> >
> > In general, it's the better not to depend on version number to check dependency.
> > Is kernel version the only way to check the kernel dependency?
>
> The tests checks for iopoll and fixed-buffer paths which are present
> from 6.1 onwards, therefore this check. Hope that is ok?
Okay, thanks for the clarification. The changes are not visible from userland,
then we need the kernel version check.
>
> > Also, I think this test case assumes that the kernel is built with
> > CONFIG_IO_URING. I suggest to add "_have_kernel_option IO_URING" to ensure it.
>
> Sure, will add.
>
> > > + _have_fio_ver 3 33
> >
> > Is io_uring_cmd engine the reason to check this fio version? If so, I suggest to
> > check "fio --enghelp" output. We can add a new helper function with name like
> > _have_fio_io_uring_cmd_engine. _have_fio_zbd_zonemode in common/fio can be a
> > reference.
>
> fixed-buffer support[1] went into this fio relese, therefore check for
> the specific version.
>
> [1]https://lore.kernel.org/fio/20221003033152.314763-1-anuj20.g@xxxxxxxxxxx/
Thanks again. This can not be checked with fio commands. Let's do with
_have_fio_ver as you suggested.
On top of this, could you renumber the test case to nvme/049? Other new test
cases will consume nvme/047 and nvme/048 soon.
