On 4/6/23 8:01 PM, Ming Lei wrote: > On Thu, Apr 06, 2023 at 04:29:43PM -0600, Jens Axboe wrote: >> On 4/5/23 9:42 PM, Yu Kuai wrote: >>> Hi, Jens! >>> >>> 在 2023/03/22 11:59, Yu Kuai 写道: >>>> From: Yu Kuai <yukuai3@xxxxxxxxxx> >>>> >>>> Currently if disk_scan_partitions() failed, GD_NEED_PART_SCAN will still >>>> set, and partition scan will be proceed again when blkdev_get_by_dev() >>>> is called. However, this will cause a problem that re-assemble partitioned >>>> raid device will creat partition for underlying disk. >>>> >>>> Test procedure: >>>> >>>> mdadm -CR /dev/md0 -l 1 -n 2 /dev/sda /dev/sdb -e 1.0 >>>> sgdisk -n 0:0:+100MiB /dev/md0 >>>> blockdev --rereadpt /dev/sda >>>> blockdev --rereadpt /dev/sdb >>>> mdadm -S /dev/md0 >>>> mdadm -A /dev/md0 /dev/sda /dev/sdb >>>> >>>> Test result: underlying disk partition and raid partition can be >>>> observed at the same time >>>> >>>> Note that this can still happen in come corner cases that >>>> GD_NEED_PART_SCAN can be set for underlying disk while re-assemble raid >>>> device. >>>> >>> >>> Can you apply this patch? >> >> None of them apply to my for-6.4/block branch... > > This patch is bug fix, and probably should aim at 6.3. Yeah I see now, but it's a bit of a mashup of 2 patches, and then a separate one. I've applied the single fixup for 6.3. -- Jens Axboe
