On Thu, Apr 06, 2023 at 04:40:52PM +0200, Christoph Hellwig wrote: > Instead of having an outer loop in __zram_make_request and then branch > out for reads vs writes for each loop iteration in zram_bvec_rw, split > the main handler into separat zram_bio_read and zram_bio_write handlers > that also include the functionality formerly in zram_bvec_rw. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > --- > drivers/block/zram/zram_drv.c | 58 ++++++++++++++++++----------------- > 1 file changed, 30 insertions(+), 28 deletions(-) > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > index 0b8e49aa3be24b..5e823dcd1975c0 100644 > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -1927,38 +1927,34 @@ static void zram_bio_discard(struct zram *zram, struct bio *bio) > bio_endio(bio); > } > > -/* > - * Returns errno if it has some problem. Otherwise return 0 or 1. > - * Returns 0 if IO request was done synchronously > - * Returns 1 if IO request was successfully submitted. > - */ It was mess from rw_page. Thanks! Acked-by: Minchan Kim <minchan@xxxxxxxxxx>
