Re: [PATCH 5/5] sed-opal: Add command to read locking range parameters.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ondrej Kozina <okozina@xxxxxxxxxx>
Subject: Re: [PATCH 5/5] sed-opal: Add command to read locking range parameters.
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 4 Apr 2023 08:27:33 -0700
Cc: linux-block@xxxxxxxxxxxxxxx, bluca@xxxxxxxxxx, gmazyland@xxxxxxxxx, axboe@xxxxxxxxx, hch@xxxxxxxxxxxxx, brauner@xxxxxxxxxx, rafael.antognolli@xxxxxxxxx
In-reply-to: <20230322151604.401680-6-okozina@redhat.com>
References: <20230322151604.401680-1-okozina@redhat.com> <20230322151604.401680-6-okozina@redhat.com>

On Wed, Mar 22, 2023 at 04:16:04PM +0100, Ondrej Kozina wrote:
> +static int response_get_column(const struct parsed_resp *resp, int *iter, u8 column, u64 *value)

Please avoid the overly long line (plus a few more later).

Otherwise this looks good to me.

References:
- [PATCH 0/5] sed-opal: add command to read locking range attributes
  - From: Ondrej Kozina
- [PATCH 5/5] sed-opal: Add command to read locking range parameters.
  - From: Ondrej Kozina

Prev by Date: Re: [PATCH 4/5] sed-opal: add helper to get multiple columns at once.
Next by Date: Re: [PATCH 0/2] bio iter improvements
Previous by thread: [PATCH 5/5] sed-opal: Add command to read locking range parameters.
Next by thread: Re: [PATCH 5/5] sed-opal: Add command to read locking range parameters.
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux