On Wed, Mar 22, 2023 at 04:16:02PM +0100, Ondrej Kozina wrote: > +{ > + int err; > + struct opal_lock_unlock *lkul = data; > + const u8 users[] = { > + OPAL_ADMIN1, > + lkul->session.who > + }; > + > + err = set_lr_boolean_ace(dev, OPAL_LOCKINGRANGE_ACE_START_TO_KEY, > + lkul->session.opal_key.lr, users, ARRAY_SIZE(users)); Please avoid the overly long line here. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>