On Mon, Mar 27, 2023 at 03:14:05PM -0700, Christoph Hellwig wrote: > On Mon, Mar 27, 2023 at 01:44:00PM -0400, Kent Overstreet wrote: > > Small patch series cleaning up/standardizing bio_for_each_segment_all(), > > which means we can use the same guts for bio_for_each_folio_all(), > > considerably simplifying that code. > > > > The squashfs maintainer will want to look at and test those changes, > > that code was doing some slightly tricky things. The rest was a pretty > > mechanical conversion. > > Can you post a code size comparism for the before and after cases? 6.2: kent@moria:~/linux$ size ktest-out/kernel_build.x86_64/vmlinux text data bss dec hex filename 13234215 5355074 872448 19461737 128f669 ktest-out/kernel_build.x86_64/vmlinux With patches: kent@moria:~/linux$ size ktest-out/kernel_build.x86_64/vmlinux text data bss dec hex filename 13234215 5355578 872448 19462241 128f861 ktest-out/kernel_build.x86_64/vmlinux