On Mar 22, 2023 / 11:16, Daniel Wagner wrote: > Setup different queues, e.g. read and poll queues. > > There is still the problem that _require_nvme_trtype_is_fabrics also includes > the loop transport which has no support for different queue types. > > See also https://lore.kernel.org/linux-nvme/20230322002350.4038048-1-kbusch@xxxxxxxx/ Hi Daniel, thanks for the patches. The new test case catches some bugs. Looks valuable. I ran the test case using various nvme_trtype on kernel v6.2 and v6.3-rc3, and observed hangs. I applied the 3rd patch in the link above on top of v6.3-rc3 and confirmed the hang disappears. I would like to wait for the kernel fix patch delivered to upstream, before adding this test case to blktests master. When I ran the test case without setting nvme_trtype, kernel reported messages below: [ 199.621431][ T1001] nvme_fabrics: invalid parameter 'nr_write_queues=%d' [ 201.271200][ T1030] nvme_fabrics: invalid parameter 'nr_write_queues=%d' [ 201.272155][ T1030] nvme_fabrics: invalid parameter 'nr_poll_queues=%d' Is it useful to run the test case with default nvme_trtype=loop? -- Shin'ichiro Kawasaki
