Hi Keith, I love your patch! Perhaps something to improve: [auto build test WARNING on axboe-block/for-next] [also build test WARNING on linus/master v6.3-rc3 next-20230322] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Keith-Busch/nvme-fabrics-add-queue-setup-helpers/20230322-082537 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next patch link: https://lore.kernel.org/r/20230322002350.4038048-2-kbusch%40meta.com patch subject: [PATCH 1/3] nvme-fabrics: add queue setup helpers config: arm-randconfig-r046-20230321 (https://download.01.org/0day-ci/archive/20230322/202303221244.KMWQNHnu-lkp@xxxxxxxxx/config) compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/0acb3964621b925db18ebec1a6c57bc3c3446859 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Keith-Busch/nvme-fabrics-add-queue-setup-helpers/20230322-082537 git checkout 0acb3964621b925db18ebec1a6c57bc3c3446859 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/nvme/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303221244.KMWQNHnu-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): In file included from drivers/nvme/host/core.c:26: >> drivers/nvme/host/fabrics.h:222:29: warning: 'struct ib_device' declared inside parameter list will not be visible outside of this definition or declaration 222 | struct ib_device *dev, u32 io_queues[HCTX_MAX_TYPES]); | ^~~~~~~~~ -- In file included from drivers/nvme/host/core.c:26: >> drivers/nvme/host/fabrics.h:222:29: warning: 'struct ib_device' declared inside parameter list will not be visible outside of this definition or declaration 222 | struct ib_device *dev, u32 io_queues[HCTX_MAX_TYPES]); | ^~~~~~~~~ In file included from drivers/nvme/host/trace.h:175, from drivers/nvme/host/core.c:30: include/trace/define_trace.h:95:42: fatal error: ./trace.h: No such file or directory 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) | ^ compilation terminated. vim +222 drivers/nvme/host/fabrics.h 205 206 int nvmf_reg_read32(struct nvme_ctrl *ctrl, u32 off, u32 *val); 207 int nvmf_reg_read64(struct nvme_ctrl *ctrl, u32 off, u64 *val); 208 int nvmf_reg_write32(struct nvme_ctrl *ctrl, u32 off, u32 val); 209 int nvmf_connect_admin_queue(struct nvme_ctrl *ctrl); 210 int nvmf_connect_io_queue(struct nvme_ctrl *ctrl, u16 qid); 211 int nvmf_register_transport(struct nvmf_transport_ops *ops); 212 void nvmf_unregister_transport(struct nvmf_transport_ops *ops); 213 void nvmf_free_options(struct nvmf_ctrl_options *opts); 214 int nvmf_get_address(struct nvme_ctrl *ctrl, char *buf, int size); 215 bool nvmf_should_reconnect(struct nvme_ctrl *ctrl); 216 bool nvmf_ip_options_match(struct nvme_ctrl *ctrl, 217 struct nvmf_ctrl_options *opts); 218 void nvme_set_io_queues(struct nvmf_ctrl_options *opts, u32 nr_io_queues, 219 u32 io_queues[HCTX_MAX_TYPES]); 220 unsigned int nvme_nr_io_queues(struct nvmf_ctrl_options *opts); 221 void nvme_map_queues(struct blk_mq_tag_set *set, struct nvme_ctrl *ctrl, > 222 struct ib_device *dev, u32 io_queues[HCTX_MAX_TYPES]); 223 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
