On 3/20/23 2:56 PM, Keith Busch wrote: > On Mon, Mar 20, 2023 at 12:49:26PM -0700, Keith Busch wrote: >> From: Keith Busch <kbusch@xxxxxxxxxx> >> >> io_uring provides the only way user space can poll completions, and that >> always sets BLK_POLL_NOSLEEP. This effectively makes hybrid polling dead >> code, so remove it and everything supporting it. > > Hybrid polling was effectively killed off with 9650b453a3d4b1, "block: ignore > RWF_HIPRI hint for sync dio", so we could add a "Fixes: " for that. It was > still potentially reachable through io_uring until d729cf9acb93119, "io_uring: > don't sleep when polling for I/O", but hybrid polling probably should not have > been reachable through that async interface from the beginning. Thanks, I'll add it as fixing both of those. More as a reference than anything else, it's not like we are backporting this change. -- Jens Axboe
