On 3/18/23 9:24?AM, Ming Lei wrote: >>> +int io_import_kbuf_for_slave(unsigned long buf_off, unsigned int len, int dir, >>> + struct iov_iter *iter, struct io_kiocb *slave) >>> +{ >> >> The kbuf naming should probably also change, as it kind of overlaps with >> the kbufs we already have and which are not really related. > > How about _bvec_buf_ or simply _buf_? Either one is fine, buf probably good enough and makes it a bit shorter. -- Jens Axboe