On Tue, Mar 14, 2023 at 11:20:14AM -0700, Eric Biggers wrote: > I did notice that attempt_merge() calls elv_merge_requests() (not to be confused > with elv_merged_request()) if it merges the requests. > > So it seems there is elv_merge_requests() which means the request was merged, > and elv_merged_request() which means the request was *not* merged... I have no > idea what is going on there :-( The naming looks very confusing, but that is indeed what the code does. The elevator code is in massive need of a cleanup, as it often is that confusing.