Hi Ming, I love your patch! Perhaps something to improve: [auto build test WARNING on axboe-block/for-next] [also build test WARNING on char-misc/char-misc-testing char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.3-rc2 next-20230314] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Ming-Lei/io_uring-add-IO_URING_F_FUSED-and-prepare-for-supporting-OP_FUSED_CMD/20230307-222928 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next patch link: https://lore.kernel.org/r/20230307141520.793891-14-ming.lei%40redhat.com patch subject: [PATCH V2 13/17] block: ublk_drv: grab request reference when the request is handled by userspace config: microblaze-randconfig-s033-20230308 (https://download.01.org/0day-ci/archive/20230315/202303151232.tHK2H9T3-lkp@xxxxxxxxx/config) compiler: microblaze-linux-gcc (GCC) 12.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://github.com/intel-lab-lkp/linux/commit/8e1a2115a8d58ff04cbc1aad6192805e29d0b63e git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Ming-Lei/io_uring-add-IO_URING_F_FUSED-and-prepare-for-supporting-OP_FUSED_CMD/20230307-222928 git checkout 8e1a2115a8d58ff04cbc1aad6192805e29d0b63e # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=microblaze olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=microblaze SHELL=/bin/bash drivers/block/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303151232.tHK2H9T3-lkp@xxxxxxxxx/ sparse warnings: (new ones prefixed by >>) >> drivers/block/ublk_drv.c:688:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected int res @@ got restricted blk_status_t [usertype] @@ drivers/block/ublk_drv.c:688:21: sparse: expected int res drivers/block/ublk_drv.c:688:21: sparse: got restricted blk_status_t [usertype] drivers/block/ublk_drv.c:697:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected int res @@ got restricted blk_status_t @@ drivers/block/ublk_drv.c:697:21: sparse: expected int res drivers/block/ublk_drv.c:697:21: sparse: got restricted blk_status_t drivers/block/ublk_drv.c:728:33: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted blk_status_t [usertype] error @@ got int res @@ drivers/block/ublk_drv.c:728:33: sparse: expected restricted blk_status_t [usertype] error drivers/block/ublk_drv.c:728:33: sparse: got int res >> drivers/block/ublk_drv.c:688:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected int res @@ got restricted blk_status_t [usertype] @@ drivers/block/ublk_drv.c:688:21: sparse: expected int res drivers/block/ublk_drv.c:688:21: sparse: got restricted blk_status_t [usertype] drivers/block/ublk_drv.c:697:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected int res @@ got restricted blk_status_t @@ drivers/block/ublk_drv.c:697:21: sparse: expected int res drivers/block/ublk_drv.c:697:21: sparse: got restricted blk_status_t drivers/block/ublk_drv.c:728:33: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted blk_status_t [usertype] error @@ got int res @@ drivers/block/ublk_drv.c:728:33: sparse: expected restricted blk_status_t [usertype] error drivers/block/ublk_drv.c:728:33: sparse: got int res >> drivers/block/ublk_drv.c:688:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected int res @@ got restricted blk_status_t [usertype] @@ drivers/block/ublk_drv.c:688:21: sparse: expected int res drivers/block/ublk_drv.c:688:21: sparse: got restricted blk_status_t [usertype] drivers/block/ublk_drv.c:697:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected int res @@ got restricted blk_status_t @@ drivers/block/ublk_drv.c:697:21: sparse: expected int res drivers/block/ublk_drv.c:697:21: sparse: got restricted blk_status_t drivers/block/ublk_drv.c:728:33: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted blk_status_t [usertype] error @@ got int res @@ drivers/block/ublk_drv.c:728:33: sparse: expected restricted blk_status_t [usertype] error drivers/block/ublk_drv.c:728:33: sparse: got int res vim +688 drivers/block/ublk_drv.c 677 678 /* todo: handle partial completion */ 679 static inline void __ublk_complete_rq(struct request *req) 680 { 681 struct ublk_queue *ubq = req->mq_hctx->driver_data; 682 struct ublk_io *io = &ubq->ios[req->tag]; 683 unsigned int unmapped_bytes; 684 int res = BLK_STS_OK; 685 686 /* called from ublk_abort_queue() code path */ 687 if (io->flags & UBLK_IO_FLAG_ABORTED) { > 688 res = BLK_STS_IOERR; 689 goto exit; 690 } 691 692 /* failed read IO if nothing is read */ 693 if (!io->res && req_op(req) == REQ_OP_READ) 694 io->res = -EIO; 695 696 if (io->res < 0) { 697 res = errno_to_blk_status(io->res); 698 goto exit; 699 } 700 701 /* 702 * FLUSH, DISCARD or WRITE_ZEROES usually won't return bytes returned, so end them 703 * directly. 704 * 705 * Both the two needn't unmap. 706 */ 707 if (req_op(req) != REQ_OP_READ && req_op(req) != REQ_OP_WRITE) 708 goto exit; 709 710 /* for READ request, writing data in iod->addr to rq buffers */ 711 unmapped_bytes = ublk_unmap_io(ubq, req, io); 712 713 /* 714 * Extremely impossible since we got data filled in just before 715 * 716 * Re-read simply for this unlikely case. 717 */ 718 if (unlikely(unmapped_bytes < io->res)) 719 io->res = unmapped_bytes; 720 721 if (blk_update_request(req, BLK_STS_OK, io->res)) 722 blk_mq_requeue_request(req, true); 723 else 724 __blk_mq_end_request(req, BLK_STS_OK); 725 726 return; 727 exit: 728 blk_mq_end_request(req, res); 729 } 730 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
